Apply suggestions from code review

Co-authored-by: Sebastian Dröge <sebastian@centricular.com>
servo · Feb 29, 2024 · f5624fa · f5624fa
1 parent 227576b
commit f5624fa
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/backends/gstreamer/datachannel.rs b/backends/gstreamer/datachannel.rs
@@ -1,5 +1,4 @@
-use glib::object::ObjectExt;
-use glib::value::ToSendValue;
+use glib::prelude::*;
 use gst_webrtc::{WebRTCDataChannel, WebRTCDataChannelState};
 use servo_media_webrtc::thread::InternalEvent;
 use servo_media_webrtc::WebRtcController as WebRtcThread;

diff --git a/backends/gstreamer/lib.rs b/backends/gstreamer/lib.rs
@@ -18,8 +18,7 @@ use ipc_channel::ipc::IpcSender;
 use log::warn;
 use media_stream::GStreamerMediaStream;
 use mime::Mime;
-use once_cell::sync::Lazy;
-use once_cell::sync::OnceCell;
+use once_cell::sync::{Lazy, OnceCell};
 use registry_scanner::GSTREAMER_REGISTRY_SCANNER;
 use servo_media::{Backend, BackendInit, SupportsMediaType};
 use servo_media_audio::context::{AudioContext, AudioContextOptions};

diff --git a/backends/gstreamer/source.rs b/backends/gstreamer/source.rs
@@ -243,7 +243,6 @@ mod imp {
 
             let pad_templ = klass.pad_template("src").unwrap();
             let ghost_pad = gst::GhostPad::builder_from_template(&pad_templ)
-                .name("src")
                 .query_function(|pad, parent, query| {
                     ServoSrc::catch_panic_pad_function(
                         parent,