Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builds on Windows with the Beta branch are broken #334

Closed
Redfire75369 opened this issue Jan 7, 2023 · 9 comments
Closed

Builds on Windows with the Beta branch are broken #334

Redfire75369 opened this issue Jan 7, 2023 · 9 comments

Comments

@Redfire75369
Copy link
Contributor

Redfire75369 commented Jan 7, 2023 •
edited
Loading

It's very similar to the issue in #327. rustc is unable to read the archive file.

Action Report on spiderfire: https://github.com/Redfire75369/spiderfire/actions/runs/3860919044/jobs/6581558820
Action Report on mozjs: https://github.com/Redfire75369/mozjs/actions/runs/3861092537/jobs/6581850000

error: failed to add native library D:\a\mozjs\mozjs\target\debug\build\mozjs_sys-4062d5cd7cbc7110\out\build/js/src/build\js_static.lib: Unsupported archive identifier

This really seems to imply that something recent in the object crate is causing this.
It also seems likely that the reason the UWP builds were failing is because they were built with nightly.
@jdm
Copy link
Member

jdm commented Jan 7, 2023 •
edited
Loading

Want to experiment with a local rustc build to test that theory?

@Redfire75369
Copy link
Contributor Author

I'll try with nightly, since I don't have a beta toolchain installed. Give me a while

@Redfire75369
Copy link
Contributor Author

Redfire75369 commented Jan 7, 2023 •
edited
Loading

I get exactly the same issue:

error: failed to add native library C:\Users\Redfire\software\github\mozjs\target\debug\build\mozjs_sys-9909ed28f55c17ac\out\build/js/src/build\js_static.lib: Unsupported archive identifier

Weird thing is dumpbin can't read it and neither can 7-zip

@sagudev
Copy link
Member

sagudev commented Jan 21, 2023 •
edited
Loading

I rerun CI on the branch where I scripted UWP CI support. The new build is failing so it's rust issue or something changed in GitHub actions hosting environment.

Here is original build: https://github.com/sagudev/mozjs/actions/runs/3516546682/jobs/5893248783
Here is failing build: https://github.com/sagudev/mozjs/actions/runs/3973814272/jobs/6812706164

@sagudev
Copy link
Member

sagudev commented Jan 21, 2023

Hm, I noticed when doing diff between outputs that even though we have hard-coded nightly install we ste used latest nightly for the process. Now that I fixed it in UWP branch we still get some errors (on al windows targets but arm64-uwp). https://github.com/sagudev/mozjs/actions/runs/3973906984/jobs/6812850087

@sagudev sagudev mentioned this issue Jan 21, 2023
Merged
@sagudev
Copy link
Member

sagudev commented Jan 21, 2023 •
edited
Loading

I am currently doing bisection.
Last know working nightly: 2022-12-03.
First known broken nightly: 2022-12-04.

@sagudev
Copy link
Member

sagudev commented Jan 21, 2023

I believe I found the problematic push in rust: rust-lang/rust#97485

@jdm jdm mentioned this issue Jan 21, 2023
Closed
@jdm
Copy link
Member

jdm commented Jan 21, 2023

Thank you for tracking that down! I have filed rust-lang/rust#107162.

@sagudev sagudev mentioned this issue Feb 4, 2023
Merged
bors-servo added a commit that referenced this issue Feb 4, 2023
@bors-servo
Auto merge of #342 - sagudev:mmake, r=jdm
405b1a4 
Fix makefile style and fallback to general cc commands & temp windows builds fix

- use `cc` instead of `gcc` and `c++` instead of `g++` for fallback on linux
- format makefile
- pin window ci to rust 1.66 due to #334
- update nightly version used for UWP
bors-servo added a commit that referenced this issue Feb 5, 2023
@bors-servo
Auto merge of #342 - sagudev:mmake, r=jdm
f84c114 
Fix makefile style and fallback to general cc commands & temp windows builds fix

- use `cc` instead of `gcc` and `c++` instead of `g++` for fallback on linux
- format makefile
- pin window ci to rust 1.66 due to #334
- update nightly version used for UWP
@sagudev
Copy link
Member

sagudev commented Sep 11, 2023

This was fixed in rust and we are using latest rust version for some time now.

@sagudev sagudev closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdm @sagudev @Redfire75369