Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cbindgen with cargo-c #343

Closed
wants to merge 1 commit into from
Closed

Conversation

linkmauve
Copy link
Contributor

cargo-c was written for rav1e’s usecase of generating and installing a C ABI the proper way, with a static library, a shared library, a pkg-config file, and the include files at the right location, and pathfinder has the exact same needs.

This requires the user to use a different command from the usual cargo build, which is why I added a README.md.

Ideally we’d add a path prefix for the include directory, to allow multiple versions to be installed at the same time until we freeze the API, but cargo-c doesn’t support it yet.

cargo-c was written for rav1e’s usecase of generating and installing a C
ABI the proper way, with a static library, a shared library, a
pkg-config file, and the include files at the right location, and
pathfinder has the exact same needs.

This requires the user to use a different command from the usual `cargo
build`, which is why I added a README.md.

Ideally we’d add a path prefix for the include directory, to allow
multiple versions to be installed at the same time until we freeze the
API, but cargo-c doesn’t support it yet.
@linkmauve
Copy link
Contributor Author

This patch is now used to build the pathfinder-git package in AUR, I’ll remove it from there once it is merged.

@pcwalton
Copy link
Contributor

This looks OK overall, except renaming the crate name. I filed lu-zero/cargo-c#83.

pcwalton added a commit to pcwalton/pathfinder that referenced this pull request Jun 24, 2020
bors-servo added a commit that referenced this pull request Jun 24, 2020
Use `cargo-c`, and update the README.

Closes #343.
@linkmauve linkmauve deleted the cargo-c branch June 24, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants