-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update port on scheme change + host parsing rules to the host setter + hash parsing rules #523
Conversation
The second commit applies host parsing rules to the host setter. The ':' handling was missing. This should let the following host example pass:
The remaining failing tests seem to mostly involve the forward slash bug. |
The last commit edits the hash setting and getting rules to match the dom url hash specification This allows the following setter test to pass:
I would love to solve the forward slash bug, but I will probably not have enough time to tackle it for now :/ |
a port setter test @nox I don't really know how to reliably handle it, is there anything I am missing I should know ? |
Ok the culprit seems to be web-platform-tests/wpt@37a9631#diff-6ef48fcfe9e518dd93d4fe48a795d3ac @SimonSapin I'll rollback until just before this commit, and push things progressively, working my way step by step |
Subset of of #537 |
On scheme change, we forgot to update the port if it's the new default one.
This will help the test :
pass later, once we're done with the forward slash appending when there's no path... which is quite a challenge for now.
This change is