GFX Support Features #172
Merged
GFX Support Features #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zicklag
force-pushed
the
gfx-support
branch
8 times, most recently
from
74b3075 to
1041594
Compare
zicklag
force-pushed
the
gfx-support
branch
2 times, most recently
from
82b962e to
e951740
Compare
Adds the ability to create a native widget from a raw window handle.
- Add cfg aliases to simplify feature checks and make sure that platform specific features will not break when enabled on unsupported platforms. - Disable X11 on MacOS. It appears it was meant to be supported, but never actually was. Disabling it so that MacOS builds can run with the X11 feature ( when desired for Linux ) without breaking. - Make the platform::unix module Linux specific ( for now? ) as Android and MacOS have their own modules and all unix backends aren't supported for Android or MacOS yet.
|
This PR now successfully works with the Other than needing a review, it is ready as far as I know. |
pcwalton
reviewed
Apr 12, 2020
|
@bors-servo: r+ |
|
📌 Commit 2925168 has been approved by |
|
☀️ Test successful - checks-travis |
This was referenced Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains additions to
surfmanneeded for supporting thegfx-backend-gleffort that is being worked on in gfx-rs/gfx#3151. Still a work in progress at the moment, but it is almost finished I think.This supercedes: pcwalton#61.
The PR adds new functions for creating a native widget from a raw window handle and will also contain fixes to allow compiling on MacOS without having to disable unsupported features.
These are both features needed by
gfx-backend-gl.