Use a simplified codepath if no bidi isolation controls are present. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there aren't any bidi isolation control characters in the paragraph, each level run directly corresponds to one isolating run sequence. In this case we can take a simplified codepath to process them.
We can easily accumulate the level runs as part of the initial explicit::compute() pass over the text; this avoids the need for a separate pass over the levels array at the beginning of prepare::isolating_run_sequences to collect them.
Manishearth
reviewed
Mar 4, 2024
src/prepare.rs
Outdated
| @@ -97,7 +101,7 @@ pub fn isolating_run_sequences( | |||
| }; | |||
|
|
|||
| isolating_run_sequences.push(IsolatingRunSequence { | |||
| runs: vec![run], | |||
| runs: vec![run.clone()], | |||
There was a problem hiding this comment.
we can use .drain() or into_iter so we can move instead
There was a problem hiding this comment.
Actually, we can just remove the .clone(), it's not needed here.
Manishearth
reviewed
Mar 4, 2024
| @@ -182,6 +190,22 @@ pub fn compute<'a, T: TextSource<'a> + ?Sized>( | |||
| levels[i + j] = levels[i]; | |||
| processing_classes[i + j] = processing_classes[i]; | |||
| } | |||
|
|
|||
| // Check if we need to start a new level run. | |||
| if i == 0 { | |||
There was a problem hiding this comment.
if we're moving level_runs logic here then we should:
- link to the spec
- mention in the fn docs that this code also handles that part of the spec
- ideally, more comments referencing spec list items or other text
There was a problem hiding this comment.
I've added/tidied up comments, as well as added a test for the edge-case of calling the paragraph API with empty text (and RTL direction, which prevents us taking the early exit in compute_bidi_info_for_para).
Manishearth
approved these changes
Mar 5, 2024
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 9, 2024
… changes from servo/unicode-bidi#131. r=platform-i18n-reviewers,supply-chain-reviewers,gregtatum No change in behavior, just internal performance optimizations. Differential Revision: https://phabricator.services.mozilla.com/D203729
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Mar 12, 2024
… changes from servo/unicode-bidi#131. r=platform-i18n-reviewers,supply-chain-reviewers,gregtatum No change in behavior, just internal performance optimizations. Differential Revision: https://phabricator.services.mozilla.com/D203729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there aren't any bidi isolation control characters in the paragraph, each level run directly corresponds to one isolating run sequence. (See notes under https://www.unicode.org/reports/tr9/#BD13.) In this case we can take a simplified codepath to process them.
Also, we can avoid the need for a separate pass over the levels array to find level runs by collecting the level runs at the same time as the levels array is being set up, during explicit::compute().