Adjust aligned gradient stop colors relative to how much they were clamped #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amped Previously we were adjusting the colors relative to the entire rect. Then we adjusted the colors relative to the segment rect. We should be adjusting the colors relative to how much they were clamped. Fixes #1030
|
Thanks, looks good! |
|
📌 Commit b709b90 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 30, 2017
Adjust aligned gradient stop colors relative to how much they were clamped Previously we were adjusting the colors relative to the entire rect. Then we adjusted the colors relative to the segment rect. We should be adjusting the colors relative to how much they were clamped. Fixes #1030 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1034) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were adjusting the colors relative to the entire rect.
Then we adjusted the colors relative to the segment rect.
We should be adjusting the colors relative to how much they were clamped.
Fixes #1030
This change is