Add ANGLE rendering in Wrench #2529
Conversation
SimonSapin
force-pushed
the
angle-wrench
branch
from
d5eafe8
to
1b36aed
Compare
| use glutin::os::windows::WindowExt; | ||
|
|
||
| // FIXME: &context_builder.pf_reqs https://github.com/tomaka/glutin/pull/1002 | ||
| let pf_reqs = &glutin::PixelFormatRequirements::default(); |
There was a problem hiding this comment.
At the moment Wrench does not call any ContextBuilder method that touches the pixel format requirements, so using default() doesn’t make a difference.
|
This should cover #741. |
| } | ||
|
|
||
| // analyzing each config | ||
| macro_rules! attrib { |
There was a problem hiding this comment.
nit: could you make this a simple function instead of a macro?
There was a problem hiding this comment.
This is code copy/pasted from Glutin. I’d rather limit changes made to it to removing stuff, in order to make things easier in case we want to backport future changes from glutin.
|
@bors-servo r+ |
|
📌 Commit 1b36aed has been approved by |
Add ANGLE rendering in Wrench The `--angle` command-line parameter enables it on Windows, when `--headless` is not also used. It panics on non-Windows. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2529) <!-- Reviewable:end -->
|
💔 Test failed - status-taskcluster |
The `--angle` command-line parameter enables it on Windows, when `--headless` is not also used. It panics on non-Windows.
SimonSapin
force-pushed
the
angle-wrench
branch
from
1b36aed
to
06c43ed
Compare
|
@bors-servo r=nical Tidy |
|
📌 Commit 06c43ed has been approved by |
Add ANGLE rendering in Wrench The `--angle` command-line parameter enables it on Windows, when `--headless` is not also used. It panics on non-Windows. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2529) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-taskcluster, status-travis |
The
--anglecommand-line parameter enables it on Windows, when--headlessis not also used. It panics on non-Windows.This change is