Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a parsing bug for project-id #33

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Conversation

emil0r
Copy link
Contributor

@emil0r emil0r commented Oct 3, 2022

Sentry.io has started to give out project numbers that are bigger than an integer. This patch changes the parsing of the project id to a long, instead of an integer.

In addition, the few dependencies that exists are upgraded to the latest version, with a special mention to clj-http-lite. The clj-commons version is used there, as it is maintained.

Sentry.io has started to give out project numbers that are bigger than
an integer. This patch changes the parsing of the project id to a
long, instead of an integer.

In addition, the few dependencies that exists are upgraded to the
latest version, with a special mention to clj-http-lite. The
clj-commons version is used there, as it is maintained.
Copy link
Collaborator

@martinklepsch martinklepsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and the ping on Slack, my GitHub notifications are somewhat unmonitored these days 🙂

Would you mind also updating the changelog? Then I'll try to merge + cut a release asap :)

Release for 1.7.0. Added notes to changes about the most important
changes from previous version.
@emil0r
Copy link
Contributor Author

emil0r commented Oct 18, 2022

Sorry that it took a while. Been a bit busy :)

@awebneck
Copy link

Any news on getting this merged and released?

@emil0r
Copy link
Contributor Author

emil0r commented Nov 1, 2022

Ping @martinklepsch :)

@martinklepsch martinklepsch merged commit 144c85c into sethtrain:master Nov 2, 2022
@martinklepsch
Copy link
Collaborator

martinklepsch commented Nov 2, 2022

@emil0r Thanks for the PR and adjustments & sorry it's been taking so long. I've tried to deploy the new version to Clojars today but am encountering an issue with boot's deploy tooling that I'm not able to get around by pinning Boot to a lower version.

I know this is a stretch but would you be interested in helping get the deployment tooling for this project running again? I'm pretty open as to what tool to use.

I'll also try to not take another 2 weeks to respond again :)

@emil0r
Copy link
Contributor Author

emil0r commented Nov 2, 2022

I can take a look. Looking into boot it seems to be fairly dead. So either lein or the new CLI tools. Do you want to keep boot for the other parts?

@martinklepsch
Copy link
Collaborator

I'm open to remove boot if you feel that would be best / easiest going forward. :)

@emil0r
Copy link
Contributor Author

emil0r commented Nov 3, 2022

Noted.

@emil0r
Copy link
Contributor Author

emil0r commented Nov 10, 2022

@awebneck #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants