Replaced object-hash with hash-sum to hopefully get a more determinis… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeGinnivan
force-pushed
the
change-object-hashing
branch
from
a066cf4 to
c83b4e0
Compare
JakeGinnivan
commented
May 28, 2019
| @@ -35,7 +35,7 @@ Object { | |||
| }, | |||
| Object { | |||
| "state": Object { | |||
| "fc7e58063ef49874aea8e2210fc7a6a2f9836f52": Object { | |||
There was a problem hiding this comment.
This is basically the issue, this hash should be the same on client and server, and it is for all browsers except IE11. This new library is far simpler, smaller and hopefully faster.
There was a problem hiding this comment.
Will be interested to see if this fixes some of the random issues we've had in IE11 between the SSR and client side render.
unique3
reviewed
May 28, 2019
src/data-provider.tsx
Outdated
|
|
||
| export interface Props { | ||
| initialState?: DataLoaderState | ||
| onEvent?: (event: DataProviderEvents) => void | Promise<any> | ||
| isServerSideRender?: boolean | ||
| resources: DataLoaderResources<any> | ||
| globalProps?: object | ||
| /** Override the object hasing function */ |
unique3
approved these changes
May 28, 2019
Tombre
approved these changes
May 28, 2019
mandymichael
approved these changes
May 28, 2019
cwoodley
approved these changes
May 28, 2019
antonjb
approved these changes
May 28, 2019
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tic hash