Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to run on multiple files at once #16

Conversation

voletiv
Copy link

@voletiv voletiv commented Nov 3, 2017

No description provided.

@severin-lemaignan
Copy link
Owner

@voletiv thank you for your contribution. I'm happy to merge this feature, but instead of creating a new gazr_benchmark_head_pose_multiple_frames binary which is almost the same as the 'single file' one, could you instead add a command-line option to the 'single file' version to accept a list of files to process?

Something like:

./gazr_benchmark_head_pose --files frames.txt ../share/shape_predictor_68_face_landmarks.dat

@voletiv voletiv force-pushed the multiple-images-minimum-changes-from-base branch 2 times, most recently from 825ac66 to fef52c5 Compare November 9, 2017 12:18
@voletiv
Copy link
Author

voletiv commented Nov 9, 2017

@severin-lemaignan Done! Please check.

@severin-lemaignan
Copy link
Owner

Great. Can you squash your 3 commits into a single one, and then, I'll merge your PR.

@voletiv voletiv force-pushed the multiple-images-minimum-changes-from-base branch from d51a431 to 3a7d810 Compare November 15, 2017 11:43
@voletiv
Copy link
Author

voletiv commented Nov 15, 2017

Squashed, please check.

Made same file for single images and multiple images in a .txt file
@voletiv voletiv force-pushed the multiple-images-minimum-changes-from-base branch from 3a7d810 to 318ea75 Compare November 15, 2017 11:48
@severin-lemaignan severin-lemaignan merged commit 55f3f52 into severin-lemaignan:master Nov 15, 2017
@severin-lemaignan
Copy link
Owner

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants