Skip to content

Commit

Permalink
[BEAM-5987] Remove @nullable annotation from SideInputReader.get()
Browse files Browse the repository at this point in the history
Generic types are de-facto @nullable so this annotation is redundant and
probably only existed to make FindBugs happy.
  • Loading branch information
iemejia committed Feb 8, 2019
1 parent a9117f9 commit 72627eb
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
*/
package org.apache.beam.runners.core;

import javax.annotation.Nullable;
import org.apache.beam.sdk.transforms.windowing.BoundedWindow;
import org.apache.beam.sdk.values.PCollectionView;

Expand All @@ -32,7 +31,6 @@ public interface SideInputReader {
* <p>It is valid for a side input to be {@code null}. It is <i>not</i> valid for this to return
* {@code null} for any other reason.
*/
@Nullable
<T> T get(PCollectionView<T> view, BoundedWindow window);

/** Returns true if the given {@link PCollectionView} is valid for this reader. */
Expand Down

0 comments on commit 72627eb

Please sign in to comment.