Initial support for OpenSSL 3.0.0-alpha17 #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures are due to openssl/openssl#12543. |
sfackler
changed the title
sfackler
changed the title
sfackler
changed the title
sfackler
changed the title
|
OpenSSL migration guide merged into the master branch: https://github.com/openssl/openssl/blob/master/doc/man7/migration_guide.pod |
|
In which release will openssl 3.0.0 support added ? |
|
The release made yesterday. |
cuviper
added a commit
to cuviper/rust
that referenced
this pull request
Jun 22, 2021
This updates the `openssl` and `openssl-sys` crates to support building the toolchain with system libraries up to OpenSSL 3.0.0. This does not affect the static version used via `openssl-src` in CI builds. ref: sfackler/rust-openssl#1264
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jun 28, 2021
Add support for OpenSSL 3.0.0 This updates the `openssl` and `openssl-sys` crates to support building the toolchain with system libraries up to OpenSSL 3.0.0. This does not affect the static version used via `openssl-src` in CI builds. ref: sfackler/rust-openssl#1264
13 tasks
divanorama
added a commit
to divanorama/nixpkgs
that referenced
this pull request
Nov 16, 2022
Upstream package didn't have recent releases. Currently build fails with something like
```
running: "/nix/store/dq0xwmsk1g0i2ayg6pb7y87na2knzylh-gcc-wrapper-11.3.0/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "/nix/store/f95kxwhnr2bazy7nl6wzwjiak02dlp9v-openssl-3.0.7-dev/include" "-Wall" "-Wextra" "-E" "build/expando.c"
cargo:warning=build/expando.c:4:24: error: pasting "RUST_VERSION_OPENSSL_" and "(" does not give a valid preprocessing token
cargo:warning= 4 | #define VERSION2(n, v) RUST_VERSION_##n##_##v
cargo:warning= | ^~~~~~~~~~~~~
cargo:warning=build/expando.c:5:23: note: in expansion of macro 'VERSION2'
cargo:warning= 5 | #define VERSION(n, v) VERSION2(n, v)
cargo:warning= | ^~~~~~~~
cargo:warning=build/expando.c:10:1: note: in expansion of macro 'VERSION'
cargo:warning= 10 | VERSION(OPENSSL, OPENSSL_VERSION_NUMBER)
cargo:warning= | ^~~~~~~
exit status: 1
```
which looks like sfackler/rust-openssl#1030
and should be fixed in a transitive dependency by sfackler/rust-openssl#1264
But rather than trying to bump transitive dependency let's downgrade
openssl used by this package.
ZHF: NixOS#199919
petr-muller
added a commit
to petr-muller/cincinnati
that referenced
this pull request
May 5, 2023
Resolves:
```
warning: build/expando.c:4:24: error: pasting "RUST_VERSION_OPENSSL_" and "(" does not give a valid preprocessing token
warning: 4 | #define VERSION2(n, v) RUST_VERSION_##n##_##v
warning: | ^~~~~~~~~~~~~
warning: build/expando.c:5:23: note: in expansion of macro 'VERSION2'
warning: 5 | #define VERSION(n, v) VERSION2(n, v)
warning: | ^~~~~~~~
warning: build/expando.c:10:1: note: in expansion of macro 'VERSION'
warning: 10 | VERSION(OPENSSL, OPENSSL_VERSION_NUMBER)
warning: | ^~~~~~~
error: failed to run custom build command for `openssl-sys v0.9.63`
```
From https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cincinnati/786/pull-ci-openshift-cincinnati-master-customrust-images/1653741007713341440#1:build-log.txt%3A3892-3900
I was inspecting that CI job and found out that bumping to CentOS Stream 9
contains a bump to OpenSSL 3.0.0 which needed special support in the
`openssl` package:
- https://bugzilla.redhat.com/show_bug.cgi?id=1948976
- sfackler/rust-openssl#1264
- rust-lang/rust#86529
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1263