add argon2id support for ossl 3.2+ #2290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Aug 31, 2024
We don't use them anywhere that isn't 3.2.0+ right now and that makes clippy angry. It can be changed if and when these get used for methods on older versions
alex
reviewed
Sep 1, 2024
alex
reviewed
Sep 1, 2024
alex
reviewed
Sep 1, 2024
alex
reviewed
Sep 1, 2024
Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com>
alex
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In argon2 there is a concept of parallelism (called lanes). Generally you'd want to have at least as many threads as you have lanes since otherwise you are trading advantage to an attacker, but OpenSSL maintains a global thread limit (as well as allowing building with
no-threads). So to use threads in this you must both set the global thread limit to greater than 1 and then also pass a thread count to the underlyingEVP_KDF_derivefunction.For this PR we simply always set threads to 1, and follow-ups will expose the global thread limit APIs and then make use of potential parallelism.