Fix deprecation warning when defining custom input #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ class ArrayInput < SimpleForm::Inputs::StringInput | |||
|
|
|||
| TEXT_FIELD_CLASSES = "text optional array-element" | |||
|
|
|||
| def input | |||
| def input(wrapper_options) | |||
There was a problem hiding this comment.
Unused method argument - wrapper_options. If it's necessary, use _ or _wrapper_options as an argument name to indicate that it won't be used. You can also write as input(*) if you want the method to accept any arguments but don't care about them.
c-lliope
force-pushed
the
deprecation
branch
from
6fff183 to
026f13d
Compare
Since heartcombo/simple_form#997, custom input adapters must accept a hash of wrapper options
c-lliope
force-pushed
the
deprecation
branch
from
026f13d to
677e5c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since heartcombo/simple_form#997,
custom input adapters must accept a hash of wrapper options