-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug of RuleSet generations #272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you write a test for this quickly?
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Chibikuri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let me write it.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @Chibikuri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you run clang-format?
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Chibikuri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @Chibikuri and @zigen)
quisp/modules/QRSA/ConnectionManager/ConnectionManager.cc, line 944 at r3 (raw file):
auto rule_entanglement_swapping = std::make_unique<Rule>(ruleset_id, rule_id, rule_name, partners); Condition *condition = new Condition(); Clause *resource_clause_left = new EnoughResourceClause(conf.left_partner, 1);
why you set this 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @zigen)
quisp/modules/QRSA/ConnectionManager/ConnectionManager.cc, line 944 at r3 (raw file):
Previously, zigen (Kentaro "zigen" Teramoto) wrote…
why you set this 1?
Oh, I mistakenly pushed this change. But I found lres represents index (==0), but enough resource clause should have the number of required resource at second argument. So this should be fixed at 1, but let me fix it in different branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Chibikuri)
quisp/modules/QRSA/ConnectionManager/ConnectionManager.cc, line 944 at r3 (raw file):
Previously, Chibikuri (Ryosuke Satoh) wrote…
Oh, I mistakenly pushed this change. But I found lres represents index (==0), but enough resource clause should have the number of required resource at second argument. So this should be fixed at 1, but let me fix it in different branch.
ah, that's right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Chibikuri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zigen)
quisp/modules/QRSA/ConnectionManager/ConnectionManager.cc, line 944 at r3 (raw file):
Previously, zigen (Kentaro "zigen" Teramoto) wrote…
ah, that's right.
Done.
Related issue #271
Problem
Currently, the order of rules is important for later processing. To point out the next rules properly, this order is required when these Rules are added to RuleSet.
Solution
In general, the distance from swapper and partners is getting larger from start to the end. To make the order of swapping proper, the swapping should be done from small distance swapping.
This change is