Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup unit tests #316

Merged
merged 5 commits into from
Dec 6, 2021
Merged

Cleanup unit tests #316

merged 5 commits into from
Dec 6, 2021

Conversation

zigen
Copy link
Contributor

@zigen zigen commented Dec 3, 2021 •
edited
Loading

after #315 , next: #317

  • update googletest to the latest master because of the C++ TestMate Extension issue
  • use MockQubit instead of MockStationaryQubit in each test file.
  • suppress warnings like the screenshot below.

スクリーンショット 2021-12-03 20 58 35

This change is Reviewable

@zigen zigen requested a review from Chibikuri December 3, 2021 11:59
@zigen zigen changed the title Suppress mock call warnings Cleanup unit tests Dec 3, 2021
@zigen zigen force-pushed the suppress-mock-call-warnings branch from 068ade2 to 04e2fc8 Compare December 4, 2021 08:52
zigen added 2 commits December 4, 2021 17:57
@zigen
update googletest to 1.11.0
66b97de
@zigen
update googletest to the latest commit
83b07b4 
according to the googletest's README.md, it is recommended to follow
the latest master.
@zigen zigen mentioned this pull request Dec 5, 2021
Merged
Chibikuri
Chibikuri approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@Chibikuri Chibikuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @zigen)

@zigen zigen merged commit d067419 into sfc-aqua:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chibikuri Chibikuri Chibikuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zigen @Chibikuri