Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update OMNeT++ msgc version to 6 #321

Merged
merged 2 commits into from
Dec 14, 2021
Merged

update OMNeT++ msgc version to 6 #321

merged 2 commits into from
Dec 14, 2021

Conversation

zigen
Copy link
Contributor

@zigen zigen commented Dec 13, 2021

update .msg files notation to version 6 in order to upgrade OMNeT++6 from 5.x.
there's a lot of const_cast to remove the const qualifier of the packet getter. but we can remove these const_cast after the RuleSet segregation.

This change is Reviewable

@zigen zigen requested review from Chibikuri and Naphann December 14, 2021 08:39
@zigen zigen marked this pull request as ready for review December 14, 2021 10:05
Copy link
Member

@Chibikuri Chibikuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Naphann)

@zigen zigen merged commit 45b00ed into master Dec 14, 2021
@zigen zigen deleted the update-to-msg6 branch August 16, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants