RuleSet into (ActiveRuleSet, RuleSet) based on their responsibility #336
Conversation
Chibikuri
changed the title
Create ActiveRuleSet and transplant current RuleSet to it.
Rename Action, Condition, Clause with ActiveAction, ActiveCondition, ActiveClause
|
@Chibikuri don't forget to merge the latest master |
Thanks, I did. |
filled addRule
There was a problem hiding this comment.
I'm not sure the ConnectionManager::respondToRequest is fine. it's time to refactor it.
Reviewed 1 of 23 files at r3, 8 of 74 files at r4, all commit messages.
Reviewable status: 9 of 107 files reviewed, 1 unresolved discussion (waiting on @Chibikuri and @zigen)
quisp/modules/QRSA/ConnectionManager/ConnectionManager.cc line 335 at r4 (raw file):
* ... */ std::map<int, std::vector<std::unique_ptr<Rule>>> rules_array;
it's a map, but it's named an array...
There was a problem hiding this comment.
let's merge it, and then refactor it. we cannot do refactor in this PR
Reviewable status: 9 of 107 files reviewed, 1 unresolved discussion (waiting on @Chibikuri and @zigen)
There was a problem hiding this comment.
Reviewable status: 9 of 107 files reviewed, 1 unresolved discussion (waiting on @zigen)
quisp/modules/QRSA/ConnectionManager/ConnectionManager.cc line 335 at r4 (raw file):
Previously, zigen (Kentaro "zigen" Teramoto) wrote…
it's a map, but it's named an array...
Done.
There was a problem hiding this comment.
Got it!
Reviewable status: 9 of 107 files reviewed, 1 unresolved discussion (waiting on @zigen)
There was a problem hiding this comment.
Reviewable status: 9 of 107 files reviewed, 1 unresolved discussion (waiting on @zigen)
There was a problem hiding this comment.
I forgot to resolve the discussion.
Reviewable status: 9 of 107 files reviewed, all discussions resolved (waiting on @zigen)
There was a problem hiding this comment.
Reviewable status: 9 of 107 files reviewed, all discussions resolved (waiting on @zigen)
There was a problem hiding this comment.
Reviewed 29 of 85 files at r1, 3 of 23 files at r3, 65 of 74 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Chibikuri)
This change is