Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix makefile #491

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Fix makefile #491

merged 3 commits into from
Feb 15, 2023

Conversation

zigen
Copy link
Contributor

@zigen zigen commented Feb 12, 2023

  • make test builds libquisp_dbg automatically
  • update git submodule separately
  • always build unit tests with debug mode
  • pass -j option for run-unit-test with coverage

This change is Reviewable

Copy link
Contributor

@Naphann Naphann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Chibikuri and @res6idue)

Copy link
Contributor

@res6idue res6idue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Chibikuri)

@zigen zigen merged commit 090f2f7 into master Feb 15, 2023
@zigen zigen deleted the fix-makefile branch August 16, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants