Merge pull request #61 from sfcheung/devel

0.1.3.16: Fix x_net_y for nonconvergence

.github/workflows/R-CMD-check.yaml

@@ -3,6 +3,8 @@
 on:
   push:
     branches: [main, master]
+  pull_request:
+    branches: [main, master]
 
 name: R-CMD-check
 

.github/workflows/pkgdown.yaml

@@ -3,6 +3,8 @@
 on:
   push:
     branches: [main, master]
+  pull_request:
+    branches: [main, master]
   release:
     types: [published]
   workflow_dispatch:

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: modelbpp
 Title: Model BIC Posterior Probability
-Version: 0.1.3.15
+Version: 0.1.3.16
 Authors@R:
     c(person(given = "Shu Fai",
              family = "Cheung",
@@ -28,7 +28,7 @@ Description: Fits the neighboring models of a fitted
 License: GPL (>= 3)
 Encoding: UTF-8
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.3.1
+RoxygenNote: 7.3.2
 Suggests:
     knitr,
     rmarkdown,

NEWS.md

@@ -1,4 +1,4 @@
-# modelbpp 0.1.3.15
+# modelbpp 0.1.3.16
 
 ## New Features
 
@@ -61,6 +61,12 @@
   Print them by setting `cumulative_bpp`
   to `TRUE`. (0.1.3.15)
 
+- Update an internal function to handle
+  nonconvergence in checking nested
+  relation. Only affect the graphs and
+  only happen in some rare cases.
+  (0.1.3.16)
+
 ## Bug Fixes
 
 - The `must_not_add` argument should

R/helpers3_for_model_graph.R

@@ -151,6 +151,7 @@ models_network2 <- function(object,
                                y = models[[j]],
                                x_df = df_i,
                                y_df = df_j)
+            if (is.na(net_chk)) next
             if (net_chk == "x_within_y") {
                 net_out[i, j] <- df_i - df_j
               } else if (net_chk == "y_within_x") {
@@ -274,8 +275,13 @@ x_net_y <- function(x,
                            sample.nobs = f1_nobs,
                            sample.th = implied_threshold,
                            WLS.V = f1_WLS.V,
-                           NACOV = f1_NACOV)
+                           NACOV = f1_NACOV,
+                           warn = FALSE)
     if (!lavaan::lavInspect(f2_1, "converged")) {
+        # If estimation failed to converged,
+        # then do not assume a nested relation.
+        # Should not be a major problem because this only
+        # affect the graph.
         return(NA)
       }
     f2_1_chisq <- unname(lavaan::fitMeasures(f2_1, fit.measures = "chisq"))

README.md

@@ -10,7 +10,7 @@
 
 # modelbpp: Model BIC Posterior Probability <img src="man/figures/logo.png" align="right" />
 
-(Version 0.1.3.15 updated on 2024-09-04, [release history](https://sfcheung.github.io/modelbpp/news/index.html))
+(Version 0.1.3.16 updated on 2024-09-15, [release history](https://sfcheung.github.io/modelbpp/news/index.html))
 
 This package is for assessing model uncertainty in structural
 equation modeling (SEM) by the BIC posterior