Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CircleCI build and test flow to eliminate errors and start real testing #133

Open
VivekMChawla opened this issue Feb 23, 2019 · 0 comments
Open

Update CircleCI build and test flow to eliminate errors and start real testing #133

VivekMChawla opened this issue Feb 23, 2019 · 0 comments
Assignees
@VivekMChawla
Labels
chore Work that's not a bug or a feature request

Comments

@VivekMChawla
Copy link
Contributor

The CircleCI configuration provided when this project was started does not ever end up with a successful test run. This causes two problems that need to be addressed.

First, we're getting "failed" tests that have nothing to do with whether this project's code works or not. All of the Greenkeeper auto-created issues when dependencies are incremented are a testament to this.

Second, we don't actually have any valid testing for this code. We need to fix that.
@VivekMChawla VivekMChawla added the chore Work that's not a bug or a feature request label Feb 23, 2019
@VivekMChawla VivekMChawla self-assigned this Feb 23, 2019
VivekMChawla added a commit that referenced this issue Feb 23, 2019
@VivekMChawla
chore(ci): Update CircleCI config
3c35c24 
Update .circleci/config.yml to match the current default config created
by sfdx plugins:generate

Related to: #133
VivekMChawla added a commit that referenced this issue Feb 23, 2019
@VivekMChawla
chore(testing): Modify org.test.ts
a63a679 
Start explorations of automated testing by bringing the boilerplate test
code up to the most recent version from sfdx plugins:generate

Related to: #133
VivekMChawla added a commit that referenced this issue Feb 23, 2019
@VivekMChawla
chore(testing): Begin creating real tests for this package
3ec0e7f 
Delete the old "hello world" mocha tests and add my first test for
falcon:adk:create.

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 12, 2019
@VivekMChawla
chore(organization): Create integration-tests directory
2ef0abe 
We will separate unit and integration tests in order to make it clear
when running CI jobs which type of test is being run.  Also, we'll focus
the postpack tests on integration tests.

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 12, 2019
@VivekMChawla
test(integration): Create cmd.ts (CLI Command test executor)
c4d1791 
Create a custom CLI command executor that is capable of accepting mock
stdin input.  This was necessary to properly test Falcon commands that
expect interactive user input to properly function.

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 12, 2019
@VivekMChawla
test(testenv): Update test/helpers/init.js
eb715b2 
Add environment variables that are set during test initialization to
ensure portability between local and CI Build environments

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 12, 2019
@VivekMChawla
test(integration): Modify falcon/adk/create.test.ts
9bd99ff 
Modify logic that tests the falcon:adk:create command. Finalize the
first true integration test (works on local, not sure if it will work
on CircleCI yet).

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 12, 2019
@VivekMChawla
chore(dev-env): Update package.json dependencies and scripts
dea428e 
Update dependency versions.  Add new development dependencies
(cross-spawn and del) to support automated tests in Mocha.

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 12, 2019
@VivekMChawla
test(test-env): Add ADK project files for use in automated testing
f03a074 
Using the sfdx-isv/testbed-falcon-adk project as a baseline, this group
of files is the first commit related to creating a set of ADK test
projects for use during automated testing.

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 12, 2019
@VivekMChawla
test(integration): Modify falcon/adk/create.test.ts
e5bb0db 
Utilize additional ExecOptions properties that specify whether stdout
and stderr have output echoed to the console during tests.
Set the "falcon:adk:create" test to skip to ease dev of other tests.

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 12, 2019
@VivekMChawla
test(integration): Tests for falcon:adk:install
42959a1 
Create falcon/adk/install.test.ts.
Create secondary recipe file falcon-test-01B-recipe.json.
Update init.js with env var that tracks location of Falcon Test TempDir.

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 15, 2019
@VivekMChawla
test(integration): Update test + framework code
7eaf7a2 
Getting close enough on the core framework and unit test code to want
to start working on the CirlceCI side of things.  This commit forms a
solid baseline to use while working on .circleci/config.yml

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 15, 2019
@VivekMChawla
test(integration): Update test + framework code
aa381e8 
Update init.js to provide cleaner output indicating the TRUE/FALSE state
of the "Falcon Test Show" vars.  Stop skipping the first test in
install.test.ts. Minor change in debug output in cmd.ts.

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 15, 2019
@VivekMChawla
test(integration): Update create and install tests
92e6fef 
Remove all "skipped" tests and get ready for falcon:adk:create and
falcon:adk:install to run at CircleCI.  Increased the delay waiting for
the first mock stdin for falcon:adk:create.

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 15, 2019
@VivekMChawla
test(integration): Update create.test.ts
964acb7 
Comment out the "Command Succeeded" stdout check because of different
git staging/commit behavior between local and CircleCI environments.
We will go with checking for an exit code of ZERO to determine success.

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 19, 2019
@VivekMChawla
test(tools): Update cmd.ts
36147c7 
Strip ANSI escape codes from stdout and stderr "lined" output.  Set the
FORCE_COLOR environment variable in spawned process. That's why we
needed to strip the ANSI escape codes. Also, cleaned up comments so
JSDocs should be accurate now.

Related to: #133
VivekMChawla added a commit that referenced this issue Mar 19, 2019
@VivekMChawla
chore(package): Add new dev dependency
e811cce 
Add mocha-junit-reporter to dev dependencies. Mostly, this is for use
by the CI envirionment.

Related to: #133
@VivekMChawla VivekMChawla mentioned this issue May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VivekMChawla VivekMChawla

Labels
chore Work that's not a bug or a feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VivekMChawla