ballle98/AqualinkD#4: co-exist with PDA #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK I know this is a massive change set now, but it's pretty much full support of PDA mode now. SPA/Pool heater settings and freeze protect as well. |
Introducing last active timer. This will release control 5 seconds after thread terminates until 30 seconds have expired and it's time to do another status update.
removed delays from PDA init and PDA get status
Removed delays from PDA device on off
menu. This is slower but it allows gets aquapure and salt status
connect and wait for 3-5 seconds also added support for pool heater and freeze protect.
ballle98
force-pushed
the
dev/last_active
branch
from
d916447
to
d5d82d1
Compare
|
Thanks very much for your work on this. I couldn't take it as is, as it broke a lot of existing functionality. But, I did use the majority of your code. I did re-write how AqualinkD reads the menus, so should be simpler to add other functionality now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing last active timer. This will release control 5 seconds
after thread terminates until 30 seconds have expired and it's time to
do another status update.