Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ballle98/AqualinkD#42: memcpy-param-overlap in PDA Shift processing #87

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

ballle98
Copy link
Contributor

fix #86

see see ballle98#42: memcpy-param-overlap in PDA Shift processing

@@ -200,9 +205,25 @@ bool process_pda_menu_packet(unsigned char* packet, int length)
if (getLogLevel() >= LOG_DEBUG){print_menu();}
break;
case CMD_PDA_SHIFTLINES:
memcpy(_menu[1], _menu[2], (PDA_LINES-1) * (AQ_MSGLEN+1) );
// press up from top - shift menu down by 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix the other code is to test the fic

@sfeakes sfeakes merged commit 118381c into sfeakes:master Aug 22, 2019
@ballle98 ballle98 deleted the dev/pda-shift-42 branch August 22, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memcpy-param-overlap in PDA Shift processing
2 participants