Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-20568 Read unitsTest.txt, prepare to run unit tests. #20

Merged
merged 6 commits into from
Mar 6, 2020
Merged

ICU-20568 Read unitsTest.txt, prepare to run unit tests. #20

merged 6 commits into from
Mar 6, 2020

Conversation

hugovdm
Copy link
Collaborator

@hugovdm hugovdm commented Mar 5, 2020 •
edited
Loading

I'm using "WIP" to flag "Work In Progress". There are no "WIP"s in the codebase yet. :-)

This Pull Request disables unit tests whose identifiers aren't supported yet: to be re-enabled once MeasureUnit is updated.

Checklist

@hugovdm hugovdm requested review from sffc and younies March 5, 2020 15:41
@hugovdm hugovdm mentioned this pull request Mar 5, 2020
Closed
sffc
sffc requested changes Mar 6, 2020
View reviewed changes
Copy link
Owner

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good milestone; just a couple things

icu4c/source/test/intltest/unitstest.cpp Outdated

u_parseDelimitedFile(path.data(), ';', fields, kNumFields,
unitsTestDataLineFn, this, errorCode);
if (U_FAILURE(errorCode)) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errorCode is an IcuTestErrorCode. You can use errIfFailureAndReset

icu4c/source/test/intltest/unitstest.cpp
UnicodeString uExpected = UnicodeString::fromUTF8(utf8Expected);
double expected = unum_parseDouble(nf, uExpected.getBuffer(),
uExpected.length(), 0, pErrorCode);
unum_close(nf);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this works, but please use the following to convert a string to a double…

DecimalQuantity expected;
expected.setToDecNumber({uExpected.getBuffer(), uExpected.length()}, *pErrorCode);
double expectedDouble = expected.toDouble();

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently still parsing "1,000.00". When I do this with DecimalQuantity, it gives U_DECIMAL_NUMBER_SYNTAX_ERROR. Is it better to use DecimalQuantity and manually strip out the thousands separators? It seemed reasonable to me to simply treat "1,000.00" as a localised number format.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Fine to leave it as-is.

@sffc sffc merged commit 9f65f41 into sffc:units-staging Mar 6, 2020
younies added a commit that referenced this pull request Jun 17, 2020
@younies
Merge pull request #20 from hugovdm/units_router
2a6cb10 
Fix getConversionRateInfo compound-base-unit calculation bug
hugovdm added a commit to hugovdm/icu that referenced this pull request Jul 15, 2020
@hugovdm
unitsdata.cpp and associated tests
e968d88 
PR: sffc#20
Commit: 9f65f41
ICU-20568 Read unitsTest.txt, prepare to run unit tests.

PR: sffc#25
Commit: 4be0a2b
No-op/cosmetic: reformat with clang-format ident:4 line-length:105.

PR: sffc#26
Commit: 9e021f9
Parse unitPreferencesTest.txt preparing to run data-driven tests

PR: sffc#34
Commit: 12a5289
Improve test output: no more fprintfs.

PR: sffc#33
Commit: 44e9afb
Update to latest CLDR test files: b7a23f3f41 CLDR-13587.

PR: sffc#31
Commit: ca34233
Add unitsdata.cpp, getConversionRatesInfo, and unit tests.

PR: sffc#41
Commit: be7f699
Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
hugovdm added a commit to hugovdm/icu that referenced this pull request Jul 23, 2020
@hugovdm
unitsdata.cpp and associated tests
33c6e99 
PR: sffc#20
Commit: 9f65f41
ICU-20568 Read unitsTest.txt, prepare to run unit tests.

PR: sffc#25
Commit: 4be0a2b
No-op/cosmetic: reformat with clang-format ident:4 line-length:105.

PR: sffc#26
Commit: 9e021f9
Parse unitPreferencesTest.txt preparing to run data-driven tests

PR: sffc#34
Commit: 12a5289
Improve test output: no more fprintfs.

PR: sffc#33
Commit: 44e9afb
Update to latest CLDR test files: b7a23f3f41 CLDR-13587.

PR: sffc#31
Commit: ca34233
Add unitsdata.cpp, getConversionRatesInfo, and unit tests.

PR: sffc#41
Commit: be7f699
Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
hugovdm added a commit to hugovdm/icu that referenced this pull request Aug 3, 2020
@hugovdm
unitsdata.cpp and associated tests
a6a91ca 
PR: sffc#20
Commit: 9f65f41
ICU-20568 Read unitsTest.txt, prepare to run unit tests.

PR: sffc#25
Commit: 4be0a2b
No-op/cosmetic: reformat with clang-format ident:4 line-length:105.

PR: sffc#26
Commit: 9e021f9
Parse unitPreferencesTest.txt preparing to run data-driven tests

PR: sffc#34
Commit: 12a5289
Improve test output: no more fprintfs.

PR: sffc#33
Commit: 44e9afb
Update to latest CLDR test files: b7a23f3f41 CLDR-13587.

PR: sffc#31
Commit: ca34233
Add unitsdata.cpp, getConversionRatesInfo, and unit tests.

PR: sffc#41
Commit: be7f699
Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
hugovdm added a commit to hugovdm/icu that referenced this pull request Aug 3, 2020
@hugovdm
unitsdata.cpp and associated tests (bundle of PRs)
1329a29 
PR: sffc#20
Commit: 9f65f41
ICU-20568 Read unitsTest.txt, prepare to run unit tests.

PR: sffc#25
Commit: 4be0a2b
No-op/cosmetic: reformat with clang-format ident:4 line-length:105.

PR: sffc#26
Commit: 9e021f9
Parse unitPreferencesTest.txt preparing to run data-driven tests

PR: sffc#34
Commit: 12a5289
Improve test output: no more fprintfs.

PR: sffc#33
Commit: 44e9afb
Update to latest CLDR test files: b7a23f3f41 CLDR-13587.

PR: sffc#31
Commit: ca34233
Add unitsdata.cpp, getConversionRatesInfo, and unit tests.

PR: sffc#41
Commit: be7f699
Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
hugovdm added a commit to hugovdm/icu that referenced this pull request Aug 15, 2020
@hugovdm
unitsdata.cpp and associated tests (bundle of PRs)
3f84b1b 
PR: sffc#20
Commit: 9f65f41
ICU-20568 Read unitsTest.txt, prepare to run unit tests.

PR: sffc#25
Commit: 4be0a2b
No-op/cosmetic: reformat with clang-format ident:4 line-length:105.

PR: sffc#26
Commit: 9e021f9
Parse unitPreferencesTest.txt preparing to run data-driven tests

PR: sffc#34
Commit: 12a5289
Improve test output: no more fprintfs.

PR: sffc#33
Commit: 44e9afb
Update to latest CLDR test files: b7a23f3f41 CLDR-13587.

PR: sffc#31
Commit: ca34233
Add unitsdata.cpp, getConversionRatesInfo, and unit tests.

PR: sffc#41
Commit: be7f699
Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
hugovdm added a commit to hugovdm/icu that referenced this pull request Aug 28, 2020
@hugovdm
unitsdata.cpp and associated tests (bundle of PRs)
c2c3af6 
PR: sffc#20
Commit: 9f65f41
ICU-20568 Read unitsTest.txt, prepare to run unit tests.

PR: sffc#25
Commit: 4be0a2b
No-op/cosmetic: reformat with clang-format ident:4 line-length:105.

PR: sffc#26
Commit: 9e021f9
Parse unitPreferencesTest.txt preparing to run data-driven tests

PR: sffc#34
Commit: 12a5289
Improve test output: no more fprintfs.

PR: sffc#33
Commit: 44e9afb
Update to latest CLDR test files: b7a23f3f41 CLDR-13587.

PR: sffc#31
Commit: ca34233
Add unitsdata.cpp, getConversionRatesInfo, and unit tests.

PR: sffc#41
Commit: be7f699
Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
hugovdm added a commit to hugovdm/icu that referenced this pull request Sep 1, 2020
@hugovdm
ICU-20568 unitsdata.cpp and associated tests (7 PRs)
15da9df 
PR: sffc#20
Commit: 9f65f41
ICU-20568 Read unitsTest.txt, prepare to run unit tests.

PR: sffc#25
Commit: 4be0a2b
No-op/cosmetic: reformat with clang-format ident:4 line-length:105.

PR: sffc#26
Commit: 9e021f9
Parse unitPreferencesTest.txt preparing to run data-driven tests

PR: sffc#34
Commit: 12a5289
Improve test output: no more fprintfs.

PR: sffc#33
Commit: 44e9afb
Update to latest CLDR test files: b7a23f3f41 CLDR-13587.

PR: sffc#31
Commit: ca34233
Add unitsdata.cpp, getConversionRatesInfo, and unit tests.

PR: sffc#41
Commit: be7f699
Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
hugovdm added a commit to hugovdm/icu that referenced this pull request Sep 9, 2020
@hugovdm
ICU-20568 unitsdata.cpp/.h and associated tests
f4d6251 
Read unitsTest.txt, prepare to run unit tests.
PR: sffc#20
Commit: 9f65f41

No-op/cosmetic: reformat with clang-format ident:4 line-length:105.
PR: sffc#25
Commit: 4be0a2b

Parse unitPreferencesTest.txt preparing to run data-driven tests
PR: sffc#26
Commit: 9e021f9

Improve test output: no more fprintfs.
PR: sffc#34
Commit: 12a5289

Update to latest CLDR test files: b7a23f3f41 CLDR-13587.
PR: sffc#33
Commit: 44e9afb

Add unitsdata.cpp, getConversionRatesInfo, and unit tests.
PR: sffc#31
Commit: ca34233

Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
PR: sffc#41
Commit: be7f699
hugovdm added a commit to unicode-org/icu that referenced this pull request Sep 10, 2020
@hugovdm
ICU-20568 unitsdata.cpp/.h and associated tests
cf46b41 
Read unitsTest.txt, prepare to run unit tests.
PR: sffc#20
Commit: 9f65f41

No-op/cosmetic: reformat with clang-format ident:4 line-length:105.
PR: sffc#25
Commit: 4be0a2b

Parse unitPreferencesTest.txt preparing to run data-driven tests
PR: sffc#26
Commit: 9e021f9

Improve test output: no more fprintfs.
PR: sffc#34
Commit: 12a5289

Update to latest CLDR test files: b7a23f3f41 CLDR-13587.
PR: sffc#33
Commit: 44e9afb

Add unitsdata.cpp, getConversionRatesInfo, and unit tests.
PR: sffc#31
Commit: ca34233

Update unitsTest.txt and unitPreferencesTest.txt from current CLDR master
PR: sffc#41
Commit: be7f699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@younies younies Awaiting requested review from younies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovdm @sffc