-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add support for _varchar #487
Feat/add support for _varchar #487
Conversation
Thanks @Jordan-M-Young for the PR! It looks good in general, and I left a minor comment. Also can you run |
@wangxiaoying Thanks for taking a look at my PR! I just committed the requested edits (removing src/macro.rs changes and running cargo fmt) Hopefully that will fix the CI pipeline! Looking forward to seeing this merged!! |
Hey @wangxiaoying I see that the testing stage of the CI pipelines failed on this latest check. I ran
Have a nice weekend! |
Hi @Jordan-M-Young , yeah I think that's probably the issue. We use postgres official docker hub image in our CI. You can use it to test locally and see whether your insert value sql can be run on it. Have a nice weekend to you too : ) |
@wangxiaoying You were right, there was a typo in postgres.sql causing insert operation to fail. Hopefully its fixed now! |
Thank you @Jordan-M-Young ! |
This is really cool! Thanks @Jordan-M-Young ! |
Thanks for your help with this @wangxiaoying ! Looking forward to contributing more in the future. |
The goal of this PR is to solve the issue: Add support for _varchar #480. This issue centers around connectorx panicking when interacting with tables containing a varchar[] type.
To solve this, I added:
Excited to hear feedback, make edits, and hopefully merge this PR into the project! This is my first ever OS contribution so I apologize for any rookie mistakes in advance!