Push empty vec on ArrowAssoc when Option is None to fix Postgres _varchar can panic on Option.unwrap #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it fails, the resulting Chunks will have wrong size With unwrap the failure wont be so silent. Failure without unwrap: _read_sql( RuntimeError: Invalid argument error: Chunk require all its arrays to have an equal number of rows
|
Thanks @auyer , this fix looks good to me. I will try to release an alpha version for test today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading a varchar array can return error
thread '<unnamed>' panicked at 'calledOption::unwrap()on aNonevalue'I was not able to figure out what row in my database led to this error because its a large base, and this PR fixes the issue already. But it would be interesting to figure this out and add it as a test condition.
This PR also adds unwrap on try_push for Vec and Vec<Option>.
If try_push fails, the resulting Chunks will have wrong size.
I believe these failures should not be dealt with
.unwrap(), but at this point, propagating errors will be a big refactor for ConnectorX.Fixes #489