Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning removal #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Warning removal #88

wants to merge 1 commit into from

Conversation

jief666
Copy link

@jief666 jief666 commented May 28, 2019

Hi,
thanks for your great project.
Let me help a bit with some warning removal. There was no bug, just some signed/unsigned, or downcast that has to be made explicit to calm down the compiler.
I added a comment explaining why it's safe to downcast.
In some occasion, I put an assert in DEBUG mode before downcasting.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant