Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types.ts GetEventData to match Slider.tsx #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MGCoding
Copy link

Hi there react-compound-slider devs. Just a small update request to your types file so that it doesn't need to be overwritten if people want access to isTouch.

Implementation of GetEventData in Slider.tsx contains a boolean which is not present in the types.ts file. Relevant snippet here:

getEventData = (e: React.MouseEvent | React.TouchEvent, isTouch: boolean) => {

I've left isTouch as optional so that it does not break existing functionality.

Implementation of `GetEventData` in Slider.tsx contains a boolean which is not present in the types.ts file.  Relevant snippet here: https://github.com/sghall/react-compound-slider/blob/2fff320a8476d4f2b03cd6cfb83e79e916b5592e/src/Slider/Slider.tsx#L352

I've left `isTouch` as optional so that it does not break existing functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant