Update types.ts GetEventData to match Slider.tsx #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
react-compound-slider
devs. Just a small update request to your types file so that it doesn't need to be overwritten if people want access toisTouch
.Implementation of
GetEventData
in Slider.tsx contains a boolean which is not present in the types.ts file. Relevant snippet here:react-compound-slider/src/Slider/Slider.tsx
Line 352 in 2fff320
I've left
isTouch
as optional so that it does not break existing functionality.