Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vcf2zarr in GWAS tutorial notebook #1258

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

tomwhite
Copy link
Collaborator

@tomwhite tomwhite commented Sep 16, 2024

@tomwhite
Copy link
Collaborator Author

The docs build works for me locally - with the exact same set of Python package versions - but on CI it's failing with

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages/jupyter_cache/executors/utils.py", line 58, in single_nb_execution
    executenb(
  File "/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages/nbclient/client.py", line 1314, in execute
    return NotebookClient(nb=nb, resources=resources, km=km, **kwargs).execute()
  File "/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages/jupyter_core/utils/__init__.py", line 165, in wrapped
    return loop.run_until_complete(inner)
  File "/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
    return future.result()
  File "/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages/nbclient/client.py", line 709, in async_execute
    await self.async_execute_cell(
  File "/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages/nbclient/client.py", line 1062, in async_execute_cell
    await self._check_raise_for_error(cell, cell_index, exec_reply)
  File "/opt/hostedtoolcache/Python/3.10.14/x64/lib/python3.10/site-packages/nbclient/client.py", line 918, in _check_raise_for_error
    raise CellExecutionError.from_cell_and_msg(cell, exec_reply_content)
nbclient.exceptions.CellExecutionError: An error occurred while executing the following cell:
------------------
ds = sg.load_dataset("1kg.vcz")
------------------

and

�[0;31mFileNotFoundError�[0m: [Errno 2] No such file or directory: '/home/runner/work/sgkit/sgkit/docs/examples/1kg.vcz/.zmetadata'

Build docs with Python 3.10

Use %%bash for running vcf2zarr
Copy link
Collaborator

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge when you are - I haven't viewed the notebook though (github's not making it easy to look at the rendered output)

@tomwhite
Copy link
Collaborator Author

Thanks @jeromekelleher. Here's the new notebook (updates in the "Importing data from VCF" section):

https://github.com/sgkit-dev/sgkit/blob/7094d3cf192dfc25ff69456ec7f1e71e7df2c264/docs/examples/gwas_tutorial.ipynb

I'll merge it later today.

@jeromekelleher
Copy link
Collaborator

LGTM - short and sweet!

@tomwhite tomwhite added the auto-merge Auto merge label for mergify test flight label Sep 17, 2024
@tomwhite tomwhite merged commit 4eea44c into sgkit-dev:main Sep 17, 2024
17 of 19 checks passed
@tomwhite tomwhite deleted the gwas-tutorial-vcf2zarr branch September 17, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Auto merge label for mergify test flight
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GWAS tutorial to use vcf2zarr
2 participants