Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model_override_args with server #591

Closed
ValeKnappich opened this issue Jul 5, 2024 · 2 comments · Fixed by #1298
Closed

model_override_args with server #591

ValeKnappich opened this issue Jul 5, 2024 · 2 comments · Fixed by #1298
Labels

Comments

@ValeKnappich
Copy link

When using a server, one currently cannot use the model_overide_args which could be very useful, e.g. for rope scaling.

This is currently the sglang.launch_server.py:

import argparse

from sglang.srt.server import launch_server
from sglang.srt.server_args import ServerArgs

if __name__ == "__main__":
    parser = argparse.ArgumentParser()
    ServerArgs.add_cli_args(parser)
    args = parser.parse_args()
    server_args = ServerArgs.from_cli_args(args)

    launch_server(server_args, None)

The model_overide_args would be the third argument to launch_server defaulting to None. Adding a small cli parser that allows arbitrary model args would be great, e.g.

python -m sglang.launch_server --model_overide_args.rope_scaling.factor 2 --model_overide_args.rope_scaling.type linear
@merrymercy
Copy link
Contributor

@ValeKnappich Agree. Could you send a pull request to support this feature?

Copy link

github-actions bot commented Sep 8, 2024

This issue has been automatically closed due to inactivity. Please feel free to reopen it if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants