-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] Passing model_override_args
to launch_server
via the CLI.
#1298
Conversation
Prepare the server arguments from the command line arguments. | ||
|
||
Args: | ||
args: The command line arguments. Typically, it should be `sys.argv[1:]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default value of parse_args
when no arguments are passed to the function is sys.argv[1:]
.
@@ -0,0 +1,24 @@ | |||
import unittest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where should this test be added in the CI pipeline?
https://github.com/sgl-project/sglang/blob/main/.github/workflows/pr-test.yml?
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevin85421 Add it here
Lines 6 to 11 in 474317f
suites = { | |
"minimal": [ | |
"models/test_embedding_models.py", | |
"models/test_generation_models.py", | |
"sampling/penaltylib", | |
"test_chunked_prefill.py", |
This "minimal" suite will be run on CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Added 3ecf574.
@@ -12,7 +12,7 @@ def test_default(self): | |||
"python3", | |||
"-m", | |||
"sglang.bench_latency", | |||
"--model", | |||
"--model-path", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--model
could be --model-path
or --model-override-args
.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename --model-override-args
to --override-model-args
?
In the meanwhile, we can change all --model
in the code base to --model-path
to avoid future ambiguity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know when it is ready for review. |
Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com>
model_override_args
to launch_server
via the CLI.model_override_args
to launch_server
via the CLI.
@merrymercy I have already removed "WIP" from the PR title. It's ready for another review iteration. Thanks! |
Motivation
model_override_args
tolaunch_server
via the CLI.prepare_server_args
to make the logic more unit testable.Closes #591
Modifications
Checklist