Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve correctness_test issue #1002

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: resolve correctness_test issue #1002

merged 1 commit into from
Aug 9, 2024

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Aug 9, 2024

Motivation

as titled cc @merrymercy @Ying1123 @hnyls2002 @min-xu-et

tested with

python -m sglang.bench_latency --model-path internlm/internlm2-chat-7b --load-format dummy --trust-remote-code
python -m sglang.bench_latency --model-path internlm/internlm2-chat-7b --batch 1 12 14 --input-len 256 512 --output-len 32 256 --result-filename out.jsonl --trust-remote-code
python -m sglang.bench_latency --model-path internlm/internlm2-chat-7b --batch 1 12 14 --input-len 256 512 --output-len 32 256 --result-filename out.jsonl --run-name after --trust-remote-code
python -m sglang.bench_latency --result-filename out.jsonl --graph-sql="select run_name, batch_size, prefill_throughput from results" 
python -m sglang.bench_latency --model-path internlm/internlm2-chat-7b --correct --trust-remote-code

Modification

Briefly describe the changes made in this PR.

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@zhyncs zhyncs merged commit b568df5 into sgl-project:main Aug 9, 2024
3 checks passed
@zhyncs zhyncs deleted the fix branch August 9, 2024 13:21
Copy link
Contributor

@min-xu-et min-xu-et left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants