Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: add CustomOp abstraction #1027

Merged
merged 1 commit into from
Aug 11, 2024
Merged

hotfix: add CustomOp abstraction #1027

merged 1 commit into from
Aug 11, 2024

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Aug 11, 2024

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.

Motivation

  • Wait for me to verify locally

Modification

Briefly describe the changes made in this PR.

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@zhyncs zhyncs marked this pull request as draft August 11, 2024 08:31
@merrymercy
Copy link
Contributor

We also need to update here

@merrymercy merrymercy marked this pull request as ready for review August 11, 2024 09:09
@merrymercy merrymercy merged commit c245b78 into sgl-project:main Aug 11, 2024
3 checks passed
@zhyncs zhyncs deleted the tmp branch August 11, 2024 09:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants