Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix benchmark script #1185

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix benchmark script #1185

merged 1 commit into from
Aug 22, 2024

Conversation

Ying1123
Copy link
Member

@Ying1123 Ying1123 commented Aug 22, 2024 •
edited
Loading

@merrymercy merrymercy enabled auto-merge (squash) August 22, 2024 08:39
@merrymercy merrymercy merged commit 5fafcac into main Aug 22, 2024
6 checks passed
@merrymercy merrymercy deleted the bench_fix branch August 22, 2024 09:03
@min-xu-et
Copy link
Contributor

min-xu-et commented Aug 22, 2024 •
edited
Loading

thanks for the fix. I am pretty sure this part of the code was run by me, how can this bug be there in the first place?

@min-xu-et
Copy link
Contributor

Oh, I checked git blame and figure it out. The bug was mine. Sorry about that. The reqs var was created for the warmup and the buggy code keeps on using it. Great catch!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrymercy merrymercy merrymercy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ying1123 @min-xu-et @merrymercy