Fix CORS compatibility with OpenAI, vLLM, TGI, LMDeploy #1373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #333
Fix CORS compatibility with OpenAI API, vLLM, TGI, LMDeploy, TabbyAPI, and others. Currently SGLang is the only one which does not use wildcard CORS headers. This makes it annoying to make requests directly from a web page to a SGLang server, since it requires adding an extra proxy server in between to add the CORS headers.
My particular use case is an in-browser eval framework. An intermediary server is not needed for this use case, except to solve this CORS issue.
Examples:
Modifications
Add CORS middleware.