Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor] Raise exception for wrong import #1409

Merged
merged 2 commits into from
Sep 13, 2024
Merged

[Minor] Raise exception for wrong import #1409

merged 2 commits into from
Sep 13, 2024

Conversation

Ying1123
Copy link
Member

No description provided.

@Ying1123 Ying1123 requested a review from merrymercy September 13, 2024 04:03
__init__.py Outdated Show resolved Hide resolved
@merrymercy merrymercy merged commit 9a903a8 into main Sep 13, 2024
1 check passed
@merrymercy merrymercy deleted the ying-minor branch September 13, 2024 06:02
@tuukkjs
Copy link

tuukkjs commented Sep 13, 2024

Hi, just wondering if this is still correct in README?

docker run --gpus all \
    -p 30000:30000 \
    -v ~/.cache/huggingface:/root/.cache/huggingface \
    --env "HF_TOKEN=<secret>" \
    --ipc=host \
    lmsysorg/sglang:latest \
    python3 -m sglang.launch_server --model-path meta-llama/Meta-Llama-3.1-8B-Instruct --host 0.0.0.0 --port 30000

I am building an alternative version of the image defined in Dockerfile and now getting the error added in this PR when I run python3 -m sglang.launch_server...

@tuukkjs
Copy link

tuukkjs commented Sep 13, 2024

Hi, just wondering if this is still correct in README?

docker run --gpus all \
    -p 30000:30000 \
    -v ~/.cache/huggingface:/root/.cache/huggingface \
    --env "HF_TOKEN=<secret>" \
    --ipc=host \
    lmsysorg/sglang:latest \
    python3 -m sglang.launch_server --model-path meta-llama/Meta-Llama-3.1-8B-Instruct --host 0.0.0.0 --port 30000

I am building an alternative version of the image defined in Dockerfile and now getting the error added in this PR when I run python3 -m sglang.launch_server...

Yes it is still correct since it works for the lmsysorg/sglang:latest image in Docker Hub. I need to fix something in my Dockerfile - it worked before the latest updates. Anyway, my bad, apologies for disturbance!

Ying1123 added a commit that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants