-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Prometheus Metrics #1461
Closed
Closed
[WIP] Prometheus Metrics #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File "/python/sglang/srt/managers/tp_worker.py", line 142, in init You should delete python. |
add metrics
29 tasks
33 tasks
Sample of current logged metrics
|
zhyncs
requested review from
hnyls2002,
zhyncs,
ispobock and
ByronHsu
as code owners
October 24, 2024 22:10
moved to #1853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Initial integration with prometheus client to facilitate metrics logging and expose the metrics to
/metrics
, which can be collected by external Grafana collectors such as alloy.prometheus client
This is a Draft, how do I make this a draft?
Modifications
/metrics
Checklist