Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix decode stats error on output_len 1 #1585

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

HaiShaw
Copy link
Contributor

@HaiShaw HaiShaw commented Oct 6, 2024

Motivation

Fix error: Decode. median latency: nan s, median throughput: nan token/s from output_len=1, as first output token is a result of Prefill.

Modifications

  • Added condition to Decode stats gathering.
  • Increased warmup steps (output_len) minor.

Checklist

  • [+] Format your code according to the Contributor Guide.
  • [+] Add unit tests as outlined in the Contributor Guide.
  • [+] Update documentation as needed, including docstrings or example tutorials.

@merrymercy merrymercy enabled auto-merge (squash) October 6, 2024 07:59
@merrymercy merrymercy merged commit 4d08671 into sgl-project:main Oct 6, 2024
10 of 11 checks passed
measurement_results["median_decode_throughput"] = med_decode_throughput

# record decode timing from 2nd output
if output_len > 1:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

From the PoV of semantics, the check if output_len > 1 should go ahead of the line decode_latencies = [] because the decoding phase won't happen unless the specified arg (one of the values of BenchArgs.output_len) is greater than 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants