Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the port_args in bench_latency #1597

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix the port_args in bench_latency #1597

merged 1 commit into from
Oct 7, 2024

Conversation

merrymercy
Copy link
Contributor

@merrymercy merrymercy commented Oct 7, 2024

port_args should be created before launching tp processes to ensure all tp processes are using the same port.

@merrymercy merrymercy merged commit 2b302b9 into main Oct 7, 2024
9 of 11 checks passed
@merrymercy merrymercy deleted the pr-fix-bench-latency branch October 7, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant