Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit about the decorator of PortArgs.init_new #1611

Merged

Conversation

glen-amd
Copy link
Contributor

@glen-amd glen-amd commented Oct 8, 2024

Trivial issues:

  1. From both the definition and the usage of PortArgs.init_new(), it may be better to be decorated with staticmethod rather than classmethod.
  2. Even for a classmethod, the convention is typically using cls instead of self.

Motivation

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

…s.init_new()`, it may be better to be decorated with `staticmethod` rather than `classmethod`. 2) Even for a `classmethod`, the convention is typically using `cls` instead of `self`.
@merrymercy merrymercy merged commit 58093b8 into sgl-project:main Oct 11, 2024
2 of 10 checks passed
@merrymercy
Copy link
Contributor

Thanks @glen-amd. It is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants