Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date to logging messages (#1623) #1679

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Add date to logging messages (#1623) #1679

merged 4 commits into from
Oct 17, 2024

Conversation

zeng-zc
Copy link
Contributor

@zeng-zc zeng-zc commented Oct 16, 2024 •
edited
Loading

Motivation

Please refer to #1623

Modifications

  • add date to engine logging
  • add more info to uvicorn logging

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@zeng-zc zeng-zc marked this pull request as draft October 16, 2024 10:53
@merrymercy merrymercy marked this pull request as ready for review October 17, 2024 01:38
@merrymercy merrymercy merged commit 2782132 into sgl-project:main Oct 17, 2024
3 of 10 checks passed
qeternity pushed a commit to qeternity/sglang that referenced this pull request Oct 27, 2024
@zeng-zc @qeternity
Add date to logging messages (sgl-project#1623) (sgl-project#1679)
8deff69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByronHsu ByronHsu ByronHsu left review comments

@merrymercy merrymercy merrymercy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeng-zc @merrymercy @ByronHsu