Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak when doing chunked prefill #1787

Merged
merged 10 commits into from
Oct 25, 2024
Merged

Fix memory leak when doing chunked prefill #1787

merged 10 commits into from
Oct 25, 2024

Conversation

hnyls2002
Copy link
Collaborator

Motivation

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@hnyls2002 hnyls2002 marked this pull request as draft October 25, 2024 04:33
merrymercy
merrymercy requested changes Oct 25, 2024
View reviewed changes
python/sglang/global_config.py Outdated Show resolved Hide resolved
python/sglang/srt/managers/scheduler.py Outdated Show resolved Hide resolved
@hnyls2002 hnyls2002 marked this pull request as ready for review October 25, 2024 06:53
@hnyls2002 hnyls2002 requested a review from zhyncs as a code owner October 25, 2024 06:53
@hnyls2002 hnyls2002 requested a review from merrymercy October 25, 2024 07:58
@merrymercy merrymercy merged commit a2f5e75 into main Oct 25, 2024
10 of 12 checks passed
@merrymercy merrymercy deleted the fix-memory-leak branch October 25, 2024 15:01
merrymercy added a commit that referenced this pull request Oct 25, 2024
@merrymercy
Revert "Fix memory leak when doing chunked prefill (#1787)"
96cb4a9 
This reverts commit a2f5e75.
@merrymercy merrymercy mentioned this pull request Oct 25, 2024
Merged
@hnyls2002 hnyls2002 mentioned this pull request Oct 30, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrymercy merrymercy merrymercy requested changes

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@zhyncs zhyncs Awaiting requested review from zhyncs zhyncs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hnyls2002 @merrymercy