Fix Triton decode kernel & ut #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ispobock
requested review from
merrymercy,
Ying1123 and
zhyncs
as code owners
ispobock
requested review from
ByronHsu
and removed request for
Ying1123,
merrymercy and
zhyncs
ByronHsu
approved these changes
Oct 27, 2024
| @@ -534,7 +545,7 @@ def _decode_grouped_softmax_reducev_fwd( | |||
| BLOCK = 128 | |||
| batch, head_num = b_seq_len.shape[0], logits.shape[0] | |||
| kv_group_num = logits.shape[0] // v_buffer.shape[1] | |||
| BLOCK_H = max(16, triton.next_power_of_2(kv_group_num)) | |||
| BLOCK_H = max(16, min(64, triton.next_power_of_2(kv_group_num))) | |||
There was a problem hiding this comment.
LGTM. just curious - under what case will this OOM? and is it OOM on SRAM?
There was a problem hiding this comment.
The OOM is for shared memory. For deepseek-v2，the head_num is 128 if we use DP. I added this situation in the unit test.
zolinthecow
pushed a commit
to zolinthecow/sglang
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation