Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix get_memory_pool_size deadlock for DP #1830

Merged
merged 3 commits into from
Oct 29, 2024
Merged

fix get_memory_pool_size deadlock for DP #1830

merged 3 commits into from
Oct 29, 2024

Conversation

ByronHsu
Copy link
Collaborator

@ByronHsu ByronHsu commented Oct 29, 2024 •
edited
Loading

Motivation

same issue as #1825

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@ByronHsu ByronHsu merged commit 680cad2 into sgl-project:main Oct 29, 2024
12 of 13 checks passed
zolinthecow pushed a commit to zolinthecow/sglang that referenced this pull request Oct 29, 2024
@ByronHsu @zolinthecow
fix get_memory_pool_size deadlock for DP (sgl-project#1830)
0391df7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ying1123 Ying1123 Ying1123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ByronHsu @Ying1123