Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop_str of qwen2-vl template should be a tuple not a str #1834

Merged
merged 2 commits into from
Oct 29, 2024
Merged

stop_str of qwen2-vl template should be a tuple not a str #1834

merged 2 commits into from
Oct 29, 2024

Conversation

yizhang2077
Copy link
Collaborator

Motivation

bug fix for #1832

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@ByronHsu ByronHsu enabled auto-merge (squash) October 29, 2024 20:13
@ByronHsu ByronHsu merged commit d04899d into sgl-project:main Oct 29, 2024
12 of 13 checks passed
@ByronHsu ByronHsu mentioned this pull request Oct 29, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByronHsu ByronHsu ByronHsu approved these changes

@merrymercy merrymercy Awaiting requested review from merrymercy merrymercy is a code owner

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yizhang2077 @ByronHsu