Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance, Triton Kernel Args] _decode_grouped_softmax_reducev_fwd… #1845

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

HaiShaw
Copy link
Collaborator

@HaiShaw HaiShaw commented Oct 30, 2024

… speedup on ROCm

Motivation

Speedup _decode_grouped_softmax_reducev_fwd.
Test shows ~1.0% improvement to median decode throughput on MI300x with Grok-1 and FP8 (b32/i1024/o256)

Modifications

Setting optimal kernel arguments to _fwd_grouped_kernel_stage2 on ROCm.

Checklist

  • [+] Format your code according to the Contributor Guide.
  • [+] Add unit tests as outlined in the Contributor Guide.
  • [+] Update documentation as needed, including docstrings or example tutorials.

@merrymercy merrymercy merged commit 2d4ce1b into sgl-project:main Oct 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants