Fix metrics #1963
Merged
Fix metrics #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarycrayon
requested review from
merrymercy,
Ying1123,
zhyncs,
hnyls2002,
ispobock and
ByronHsu
as code owners
binarycrayon
commented
Nov 8, 2024
| @@ -452,6 +452,9 @@ def launch_server( | |||
| 2. Inter-process communication is done through ICP (each process uses a different port) via the ZMQ library. | |||
| """ | |||
|
|
|||
| if server_args.enable_metrics: | |||
There was a problem hiding this comment.
I'm happy to take suggestions here
|
TODO:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently,
/metricsis empty with--enabled-metricsflag turned on. Due to the fact that we need to set prometheus environ before app start.Modifications
Moved prometheus environ import to before launching server; added unit tests to verify that
Checklist