Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qwen2vl fix bug for #1971 #1897 #1984

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

yizhang2077
Copy link
Collaborator

Motivation

  1. fix issues about QWen VL Follow-up Fixes #1897 , move mrope_position_delta to Class ImageInputs.
  2. fix a issue about multimodal can not use the choices? #1971 , remove input_ids = None

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@yizhang2077 yizhang2077 changed the title move mrope_delta to image inputs, fix bug for #1971 qwen2vl fix bug for #1971 #1897 Nov 10, 2024
@zhyncs zhyncs merged commit a8aad93 into sgl-project:main Nov 10, 2024
13 checks passed
@merrymercy
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants