Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
NOTE:
flashinfer.apply_rope_pos_ids
does not exist in the prebuilt wheel, must build from source. Is this an issue?We want to verify the correctness of flashinfer's RoPE against vLLM's RoPE, in preparation of replacing vLLM's
get_rope
with flashinfer's.cc: @ByronHsu
Modifications
Added standalone python script for comparison.
Checklist